Previous pid leaves trailing characters

[joecroninallen]

I encountered an issue where a new pid might be shorter than the previous pid. What happens is the lock file gets written with the new PID, but there are trailing digits from the previous one, so when you try to stop the application, it fails.

I fixed this by changing the code that writes the PID to pad up to PID_MAXLEN (which is defined as 10). That way, no matter how short the pid is, it will add trailing spaces up to PID_MAXLEN characters, and there won't be any digits leftover from the previous PID.

[joecroninallen]

For reference, this is what I did to pad the output:

I changed the following line:
int len = snprintf(pid_str, PID_MAXLEN, "%d", getpid());

And this is what I changed it to:
int len = snprintf(pid_str, PID_MAXLEN + 1, "%-10d", getpid());

I hardcoded the value 10 in "%-10d" because that is what PID_MAXLEN is set to. Also, I incremented the second parameter there by 1 because it was causing the buffer to overrun, and the resulting file ended up having a weird '^@' thing at the end of it.