Skip to content

Improve displayed error by using DataFusionError's Display trait #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timsaucer merged 2 commits into from
Feb 4, 2026
Merged

Improve displayed error by using DataFusionError's Display trait #1370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9fdf01
Use instead of for
abey79 Feb 4, 2026
97f5f46
update test
abey79 Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/tests/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_err(df):
with pytest.raises(Exception) as e_info:
df["c"]

for e in ["SchemaError", "FieldNotFound", 'name: "c"']:
for e in ["Schema error", "No field named c"]:
assert e in e_info.value.args[0]

with pytest.raises(Exception) as e_info:
Expand Down
2 changes: 1 addition & 1 deletion python/tests/test_udf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,4 +207,4 @@ def non_nullable_abs(input_col):

with pytest.raises(Exception) as e_info:
_results = df_result.collect()
assert "InvalidArgumentError" in str(e_info)
assert "Invalid argument error" in str(e_info)
2 changes: 1 addition & 1 deletion src/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pub enum PyDataFusionError {
impl fmt::Display for PyDataFusionError {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
match self {
PyDataFusionError::ExecutionError(e) => write!(f, "DataFusion error: {e:?}"),
PyDataFusionError::ExecutionError(e) => write!(f, "DataFusion error: {e}"),
PyDataFusionError::ArrowError(e) => write!(f, "Arrow error: {e:?}"),
PyDataFusionError::PythonError(e) => write!(f, "Python error {e:?}"),
PyDataFusionError::Common(e) => write!(f, "{e}"),
Expand Down