Skip to content

fix(eslint-plugin-react-hooks): allow underscore prefix in component … #35638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poetryofcode wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix(eslint-plugin-react-hooks): allow underscore prefix in component … #35638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/eslint-plugin-react-hooks/__tests__/ESLintRulesOfHooks-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@ const allTests = {
}
`,
},
{
code: normalizeIndent`
// Valid because components with underscore prefix followed by uppercase are components.
function _PrivateComponent() {
useHook();
}
`,
},
{
syntax: 'flow',
code: normalizeIndent`
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-react-hooks/src/rules/RulesOfHooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function isHook(node: Node): boolean {
* always start with an uppercase letter.
*/
function isComponentName(node: Node): boolean {
return node.type === 'Identifier' && /^[A-Z]/.test(node.name);
return node.type === 'Identifier' && /^_?[A-Z]/.test(node.name);
}

function isReactFunction(node: Node, functionName: string): boolean {
Expand Down