Skip to content

Fix checkbox onChange not firing in certain click ordering cases #35704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KashviYadav09 wants to merge 2 commits into
base: main
Choose a base branch
from
+214 −863
Open

Fix checkbox onChange not firing in certain click ordering cases #35704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92d4c32
Fix onChange firing when click event is preventDefaulted
KashviYadav09 Feb 5, 2026
2162aa2
Fix checkbox onChange not firing in certain click ordering cases
KashviYadav09 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/react-dom/src/__tests__/ReactDOMEventListener-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1302,3 +1302,27 @@ describe('ReactDOMEventListener', () => {
expect(log).toEqual([false]);
});
});



it('should not fire onChange if preventDefault is called on click', async () => {
const container = document.createElement('div');
document.body.appendChild(container);

const onChange = jest.fn();

const root = ReactDOMClient.createRoot(container);
root.render(
<input
type="checkbox"
onClick={e => e.preventDefault()}
onChange={onChange}
/>
);

const input = container.querySelector('input');

input.click();

expect(onChange).not.toHaveBeenCalled();
});
36 changes: 36 additions & 0 deletions packages/react-dom/src/__tests__/ReactDOMInput-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3110,3 +3110,39 @@ describe('ReactDOMInput', () => {
expect(node.value).toBe('a');
});
});


it('fires onChange for checkbox even when parent has click handler', async () => {
const log = [];

function Parent() {
return (
<div
onClick={() => {
log.push('parent click');
}}>
<input
type="checkbox"
onChange={() => {
log.push('checkbox change');
}}
/>
</div>
);
}

const container = document.createElement('div');
document.body.appendChild(container);

const root = ReactDOMClient.createRoot(container);
root.render(<Parent />);

const checkbox = container.querySelector('input');

checkbox.click();

expect(log).toEqual([
'parent click',
'checkbox change',
]);
});
Loading