[BUG] v1.9.5: src/string_util.cc:158:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]

[sergio-nsk]

When building with LLVM clang on Windows

src/string_util.cc:158:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  158 |   std::string tmp = StrFormatImp(format, args);
      |                                  ^~~~~~
1 error generated.

System
Which OS, compiler, and compiler version are you using:

• OS: Windows 10
• Compiler and version:

clang version 21.1.4
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\Program Files\LLVM\bin 

To reproduce
Steps to reproduce the behavior:

1. Install LLVM
2. sync to the tag v1.9.5
3. cmake -S. -Bout/llvm -GNinja, it will select LLVM clang
4. cmake --build out/llvm
5. See errors

Expected behavior
Build successfully.

[dmah42]

maybe we need to turn that warning off.

[sergio-nsk]

#2126 fixes this error.