Make Date header parsing locale-independent#1663
Merged
rustam-gamidov-here merged 1 commit intomasterfrom Feb 20, 2026
Merged
Conversation
057c620 to
d5e873a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1663 +/- ##
==========================================
- Coverage 80.35% 80.31% -0.03%
==========================================
Files 350 350
Lines 14039 14051 +12
Branches 1514 1517 +3
==========================================
+ Hits 11280 11285 +5
- Misses 2146 2150 +4
- Partials 613 616 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mykolamalik
previously approved these changes
Feb 20, 2026
andrey-kashcheev
previously approved these changes
Feb 20, 2026
Parse RFC1123 Date headers with strptime_l using the classic locale and a literal GMT token, and trim header whitespace before parsing. Treat invalid/partial parses as missing timestamps and remove the extra GMT offset correction now that UTC parsing is explicit. Relates-To: HERESUP-57013 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com> Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
6fe9041
d5e873a to
6fe9041
Compare
diachenko-mischa
approved these changes
Feb 20, 2026
andrey-kashcheev
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse RFC1123 Date headers with strptime_l using the classic locale and a literal GMT token, and
trim header whitespace before parsing.
Treat invalid/partial parses as missing timestamps and remove the extra GMT offset correction now that UTC parsing is explicit.
Relates-To: HERESUP-57013