Skip to content

Make Date header parsing locale-independent#1663

Merged
rustam-gamidov-here merged 1 commit intomasterfrom
rga/make-date-header-parsing-locale-independent
Feb 20, 2026
Merged

Make Date header parsing locale-independent#1663
rustam-gamidov-here merged 1 commit intomasterfrom
rga/make-date-header-parsing-locale-independent

Conversation

@rustam-gamidov-here
Copy link
Collaborator

@rustam-gamidov-here rustam-gamidov-here commented Feb 20, 2026

Parse RFC1123 Date headers with strptime_l using the classic locale and a literal GMT token, and
trim header whitespace before parsing.

Treat invalid/partial parses as missing timestamps and remove the extra GMT offset correction now that UTC parsing is explicit.

Relates-To: HERESUP-57013

@rustam-gamidov-here rustam-gamidov-here force-pushed the rga/make-date-header-parsing-locale-independent branch 2 times, most recently from 057c620 to d5e873a Compare February 20, 2026 08:58
@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.31%. Comparing base (df55ff5) to head (6fe9041).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...k-authentication/src/AuthenticationClientUtils.cpp 55.00% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
- Coverage   80.35%   80.31%   -0.03%     
==========================================
  Files         350      350              
  Lines       14039    14051      +12     
  Branches     1514     1517       +3     
==========================================
+ Hits        11280    11285       +5     
- Misses       2146     2150       +4     
- Partials      613      616       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mykolamalik
mykolamalik previously approved these changes Feb 20, 2026
Parse RFC1123 Date headers with strptime_l using
the classic locale and a literal GMT token, and
trim header whitespace before parsing.

Treat invalid/partial parses as missing timestamps
and remove the extra GMT offset correction now that
UTC parsing is explicit.

Relates-To: HERESUP-57013

Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
@rustam-gamidov-here rustam-gamidov-here force-pushed the rga/make-date-header-parsing-locale-independent branch from d5e873a to 6fe9041 Compare February 20, 2026 15:17
@rustam-gamidov-here rustam-gamidov-here merged commit b877dc4 into master Feb 20, 2026
21 of 22 checks passed
@rustam-gamidov-here rustam-gamidov-here deleted the rga/make-date-header-parsing-locale-independent branch February 20, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments