Encoding not working because of volume argument on FFmpeg command

[matthew-balzan]

I was always getting an empty session when encoding, without getting any errors.

I manually tried the command used to encode and got this:

Unrecognized option 'vol'.
Error splitting the argument list: Option not found

So i checked the arguments the package is sending (encode.go):

// Launch ffmpeg with a variety of different fruits and goodies mixed togheter
	args := []string{
		"-stats",
		"-i", inFile,
		"-reconnect", "1",
		"-reconnect_at_eof", "1",
		"-reconnect_streamed", "1",
		"-reconnect_delay_max", "2",
		"-map", "0:a",
		"-acodec", "libopus",
		"-f", "ogg",
		"-vbr", vbrStr,
		"-compression_level", strconv.Itoa(e.options.CompressionLevel),
		"-vol", strconv.Itoa(e.options.Volume),
		"-ar", strconv.Itoa(e.options.FrameRate),
		"-ac", strconv.Itoa(e.options.Channels),
		"-b:a", strconv.Itoa(e.options.Bitrate * 1000),
		"-application", string(e.options.Application),
		"-frame_duration", strconv.Itoa(e.options.FrameDuration),
		"-packet_loss", strconv.Itoa(e.options.PacketLoss),
		"-threads", strconv.Itoa(e.options.Threads),
		"-ss", strconv.Itoa(e.options.StartTime),
	}

I dont know if this was working for an older version of FFmpeg, or it's just a Windows problem, but vol does not exists as an argument.

Removing it correctly encodes the file.

[JadeMin]

which ffmpeg versions are compatible?

[matthew-balzan]

I linked the pull request #32 with the correct volume setting, instead of just removing the line.

which ffmpeg versions are compatible?

I assume old versions had that argument as valid, since now it doesn't exist in their documentation. I'm not sure when it changed.

Unfortunately I'm using windows for this project, so the version I'm printing is something weird, like ffmpeg version 2023-07-16-git-c541ecf0dc-full_build-www.gyan.dev.