Skip to content

[ENH] improved simple assertion error message in evalutation/functions.py #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EmanAbdelhaleem wants to merge 6 commits into
base: main
Choose a base branch
from
+3 −2
Open

[ENH] improved simple assertion error message in evalutation/functions.py #1600

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b12575b
a slight fix to an asserion error message
EmanAbdelhaleem Jan 6, 2026
bb36666
Merge branch 'main' into pr/1600
fkiraly Jan 7, 2026
c246509
update assertion message
EmanAbdelhaleem Jan 13, 2026
e3b1a45
Merge branch 'slight_fix' of github.com:EmanAbdelhaleem/openml-python…
EmanAbdelhaleem Jan 13, 2026
07f4461
Merge branch 'main' into slight_fix
EmanAbdelhaleem Feb 4, 2026
33ca852
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions openml/evaluations/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,10 @@ def __list_evaluations(api_call: str) -> list[OpenMLEvaluation]:
f'Error in return XML, does not contain "oml:evaluations": {evals_dict!s}',
)

assert isinstance(evals_dict["oml:evaluations"]["oml:evaluation"], list), type(
evals_dict["oml:evaluations"],
assert isinstance(evals_dict["oml:evaluations"]["oml:evaluation"], list), (
"Expected 'oml:evaluation' to be a list, but got"
)
f"{type(evals_dict['oml:evaluations']['oml:evaluation']).__name__}. "
Comment on lines +234 to +237
Copy link
Collaborator

@geetu040 geetu040 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert isinstance(evals_dict["oml:evaluations"]["oml:evaluation"], list), (
"Expected 'oml:evaluation' to be a list, but got"
)
f"{type(evals_dict['oml:evaluations']['oml:evaluation']).__name__}. "
assert isinstance(evals_dict["oml:evaluations"]["oml:evaluation"], list), (
"Expected 'oml:evaluation' to be a list, but got"
f"{type(evals_dict['oml:evaluations']['oml:evaluation']).__name__}. "
)


uploader_ids = list(
{eval_["oml:uploader"] for eval_ in evals_dict["oml:evaluations"]["oml:evaluation"]},
Expand Down