Skip to content

fix(taskctl): commitTask marks task done even when git commit reported nothing to commit #278

@randomm

Description

@randomm

Problem

commitTask in pulse.ts marks the task as stage: done after the @ops session finishes, regardless of whether a commit was actually made. If git commit reports 'nothing to commit', the task is still closed as 'approved and committed' — silently losing all developer work.

Root Cause

commitTask (pulse.ts ~line 604) polls until the ops session is no longer actively running, then unconditionally marks the task done. It never reads the ops session output to verify a commit hash was produced.

Acceptance Criteria

  • commitTask reads the @ops session output after completion
  • If output contains 'nothing to commit', escalate as a commit failure (not mark done)
  • Task is only marked done when a commit SHA is confirmed in the ops output
  • bun test and bun run typecheck pass

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions