[PWGHF] Implement TPC pid for light nuclei based on Bethe-Bloch parametrization in HF track skimming task #14729
Conversation
github-actions
bot
changed the title
zhangbiao-phy
changed the title
github-actions
bot
changed the title
zhangbiao-phy
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano and
vkucera
as code owners
|
thanks @vkucera! I fixed your comments now, please take a look. |
| return false; | ||
| } | ||
|
|
||
| float itsPidNsigma = -999.f; |
There was a problem hiding this comment.
its is not a quantity, Pid is redundant, Nsigma is not a word.
| float itsPidNsigma = -999.f; | |
| float nSigmaIts = -999.f; |
| /// \param lightnuclei Species selector: 0=Deuteron, 1=Triton, 2=Helium3. | ||
| /// \return TPC nσ for the chosen nucleus hypothesis (or -999 if not applicable). | ||
| template <typename TrackType> | ||
| float getTPCnSigmaBB(const TrackType& track, ChannelsNucleiQA lightnuclei) |
There was a problem hiding this comment.
Follow naming conventions.
… the single track skimming task
| } | ||
| } | ||
| PROCESS_SWITCH(HfTrackIndexSkimCreatorTagSelTracks, processNoPid, "Process without PID selections", true); | ||
| PROCESS_SWITCH(HfTrackIndexSkimCreatorTagSelTracks, processNoPid, "Process without PID selections", false); |
There was a problem hiding this comment.
Why do you change the default config?
There was a problem hiding this comment.
Thanks for spotting it! I forgot to restore it
|
Thanks @fgrosa's suggestions! I move to the light nuclei track quality and pid selection into the track tag task now. Then used it into the pid selection on top of 3prong candidates pre-selection |
[PWGHF] Please consider the following formatting changes to AliceO2Group#14729
| template <int PidStrategy, typename T> | ||
| uint8_t isSelectedPid(const T& hfTrack) | ||
| template <int PidStrategy, typename T, typename TrackWithIts> | ||
| uint8_t isSelectedPid(const T& hfTrack, const TrackWithIts& hfTrackWithIts) |
There was a problem hiding this comment.
Please update the documentation.
There was a problem hiding this comment.
Not fixed. The function does not return bool.
There was a problem hiding this comment.
ah, I didn't get your point before. It's fixed now
Please consider the following formatting changes to AliceO2Group#14729
|
Hi @vkucera, Could you please take a look this pr? let me know if you have any further comments. Thanks a lot! |
3 participants
@fgrosa, the BB parametrization is validated with two diffrent analysis of LF