[PWGHF] Make default sgSelector parameters configurable

[Rrantu]

1. The default values of NDtColl, MinNBCs, MinNTracks and MaxNTracksFix in utilsUpcHf.h were not optimal and have been changed to Configurable parameters.
2. Reduced the number of bins in the UPC QA histograms in taskLc.cxx to optimize memory usage.

[vkucera]

Hi @Rrantu , when these parameters were being added, my understanding was that these were already optimised constants taken from the UD. Can you please explain the motivation of your PR?
Btw, your changes do not modify the defaults of the SGSelector class. Fix the title.

[Rrantu]

Hi @Rrantu , when these parameters were being added, my understanding was that these were already optimised constants taken from the UD. Can you please explain the motivation of your PR? Btw, your changes do not modify the defaults of the SGSelector class. Fix the title.

Hi @vkucera, the original default values were not fully consistent with the UD configurations. I have now made these parameters configurable based on the settings used in the UD analysis.

[vkucera]

• Fix the names.
• Why is fFITTimeMax initialised with int?
• The default values should be taken from defaults.

[Rrantu]

Hi @vkucera, thanks for your comments, I have fixed the name. And the initialization of fFITTimeMax follows the implementation in this file:
#

O2Physics/PWGDQ/Tasks/filterPbPb.cxx

Line 46 in 93e4fbf

Configurable<float> fConfigMaxFITTime{"cfgMaxFITTime", 4, "Maximum time in FIT"};

[vkucera]

The initialisation in the DQ file is wrong.

[vkucera]

Suggested change

	o2::framework::Configurable<int> nDtColl{"nDtColl", 1, "Number of standard deviations to consider in BC range"};
	o2::framework::Configurable<int> nBCsMin{"nBCsMin", 2, "Minimum number of BCs to consider in BC range"};
	o2::framework::Configurable<int> nPVCsMin{"nPVCsMin", 2, "Minimum number of PV contributors"};
	o2::framework::Configurable<int> nPVCsMax{"nPVCsMax", 1000, "Maximum number of PV contributors"};
	o2::framework::Configurable<float> fITTimeMax{"fITTimeMax", 34, "Maximum time in FIT"};
	o2::framework::Configurable<int> nDtColl{"nDtColl", 1, "Number of standard deviations to consider in BC range"};
	o2::framework::Configurable<int> nBcsMin{"nBcsMin", 2, "Minimum number of BCs to consider in BC range"};
	o2::framework::Configurable<int> nContributorsPvMin{"nContributorsPvMin", 2, "Minimum number of PV contributors"};
	o2::framework::Configurable<int> nContributorsPvMax{"nContributorsPvMax", 1000, "Maximum number of PV contributors"};
	o2::framework::Configurable<float> timeFitMax{"timeFitMax", 34, "Maximum time in FIT"};

[vkucera]

Same name fixes.

[vkucera]

Please remove zdcThreshold. It is unused.

[Rrantu]

Thanks for your suggestions, I've updated the code.

[vkucera]

Thanks. Please implement the remaining changes I had requested.

[Rrantu]

Sorry, I missed one of the changes earlier. It has now been fixed.

[vkucera]

Also the default values.

[Rrantu]

The default value now matches the one in this file:
#

O2Physics/PWGHF/Utils/utilsEvSelHf.h

Lines 230 to 233 in 8cb945f

	sgCuts.SetNDtcoll(1); // Minimum number of sigma around the collision
	sgCuts.SetMinNBCs(2); // Minimum number of bunch crossings
	sgCuts.SetNTracks(2, 1000); // Minimum and maximum number of PV contributors
	sgCuts.SetMaxFITtime(34.f); // Maximum FIT time in ns

Please let me know if this is okay

[vkucera]

Sorry, I don't understand why we have 3 independent sets of these values now:

• o2::analysis::hf_upc::HfUpcGapThresholds
• o2::analysis::hf_upc::defaults
• o2::hf_evsel::HfEventSelection::setSgPreselection

Maybe @zhangbiao-phy can clarify.