Open
Conversation
All rules should not be applied for each filter. Filters and rules should be applied independent of each other.
mlhetland
reviewed
Dec 9, 2019
mlhetland
left a comment
mlhetland
left a comment
There was a problem hiding this comment.
This isn’t quite right. The idea is that first all the filters are applied, and then all the rules. With this edit, all the rules would be applied multiple times, once for each time a filter is used.
mlhetland
approved these changes
Dec 9, 2019
There was a problem hiding this comment.
Ah! I’m sorry, I was checking my original code to see what could have happened, and that code (probably present in 2nd ed.), was correct. So I flipped which version was which, here. Certainly, the rule thing should not be inside the filter thing. You’re absolutely correct. This was probably introduced by typesetting issues, and extracting the code from that. Sorry about the confusion!
Author
|
Great! Thanks :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All rules should not be applied for each filter. Filters and rules should be applied independent of each other.