fix: check native source correctly#2967
Merged
HerrCai0907 merged 2 commits intoAssemblyScript:mainfrom Dec 27, 2025
Merged
Conversation
native code's internal path is ~lib/native.ts instead of ~lib. However, it is more easier to check current source is same as static _native field.
CountBleck
requested changes
Dec 27, 2025
Member
CountBleck
left a comment
CountBleck
left a comment
There was a problem hiding this comment.
Source._native is lazily initialized. Maybe just fix the line to say LIBRARY_PREFIX + "native.ts" (what Source.native contains verbatim).
You could also do return this == Source.native but I think that defeats the purpose of both lazy-initializing and the optimization you were trying to make.
Member
Author
lazy init is ok. When |
Member
|
Silly me |
CountBleck
approved these changes
Dec 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
native code's internal path is ~lib/native.ts instead of ~lib.
However, it is more easier to check current source is same as static
_native field.
Fixes # .
Changes proposed in this pull request:
⯈
⯈
⯈