Add more dynamic settings.#213
Open
bluecamel wants to merge 4 commits intoAutonomyLab:indigo-develfrom
Open
Conversation
added 4 commits
May 17, 2020 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few more dynamic settings. I had to fork arsdk-xml to change some command names, so generate.py is pointing to my fork. I imagine that you'll want to do this differently, but since arsdk-xml is pretty far ahead of the original commit, I'm not sure how you'd want to handle it. Maybe it makes sense to just put the xml file in parrot_arsdk?
I also added a script that automatically fixes the generated files and removed that section from the docs.
Let me know how you'd like to handle this and I'll make any needed changes. At the very least, I wanted to share this with others. It's pretty nice to be able to change white balance, saturation, and exposure with rqt_reconfigure.