Conversation
| <rosparam command="load" file="$(arg config_file)" /> | ||
| </node> | ||
| <include file="$(find bebop_description)/launch/description.launch" /> | ||
| <!--include file="$(find bebop_description)/launch/description.launch" /--> |
There was a problem hiding this comment.
Could you please revert back this line? I understand that Bebop's URDF does not match Disco's, but that should be fixed in a more generalized way.
|
Thank you for submitting this PR. Please see my comment. |
|
@mani-monaj Please check. |
| <rosparam command="load" file="$(arg config_file)" /> | ||
| </node> | ||
| <include file="$(find bebop_description)/launch/description.launch" /> | ||
| <include file="$(find bebop_description)/launch/description.launch"> |
There was a problem hiding this comment.
Thanks for re-enabling this. However this will not run since it's not a valid XML. Please also add back the missing />. It might be easier to just checkout bode_node.launch from upstream.
| { | ||
| gps_state_ptr = bebop_ptr_->ardrone3_pilotingstate_positionchanged_ptr->GetDataCstPtr(); | ||
| if ((gps_state_ptr->header.stamp - last_gps_time).toSec() > util::eps) | ||
| //if ((gps_state_ptr->header.stamp - last_gps_time).toSec() > util::eps) |
There was a problem hiding this comment.
Sorry for my delayed feedback and thanks for making all the changes. I will merge it in very soon. Please also remove this commented line. Also, please consider adding your name to the following file as part of this pull request: https://github.com/AutonomyLab/bebop_autonomy/blob/indigo-devel/docs/contribute.rst
2 participants
No description provided.