[Compute] Add VMSS Automatic Zone Placement CLI Support#32771
Open
[Compute] Add VMSS Automatic Zone Placement CLI Support#32771
Conversation
huiii99
requested review from
jsntcy,
wangzelin007 and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vmss create | cmd vmss create added parameter exclude_zones |
||
| vmss create | cmd vmss create added parameter include_zones |
||
| vmss create | cmd vmss create added parameter instance_percent_policy |
||
| vmss create | cmd vmss create added parameter max_instance_percent |
||
| vmss create | cmd vmss create added parameter max_zone_count |
||
| vmss create | cmd vmss create added parameter zone_placement_policy |
||
| vmss update | cmd vmss update added parameter instance_percent_policy |
||
| vmss update | cmd vmss update added parameter max_instance_percent |
||
| vmss update | cmd vmss update added parameter max_zone_count |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Azure CLI support for VMSS “Automatic Zone Placement” and related zone allocation policies for az vmss create and az vmss update, plus scenario tests/recordings to validate the new flags and server payloads.
Changes:
- Add new CLI parameters for zone placement (
--zone-placement-policy,--include-zones,--exclude-zones) onvmss create. - Add/extend zone allocation policy support (
--max-zone-count,--instance-percent-policy,--max-instance-percent) forvmss createandvmss update, including validation and request shaping. - Add scenario tests and recordings covering create/update flows and key validation errors.
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Wires new zone allocation policy args into VMSS update request payload. |
| src/azure-cli/azure/cli/command_modules/vm/_template_builder.py | Adds placement and resiliencyPolicy.zoneAllocationPolicy to ARM template deployment payload for VMSS create. |
| src/azure-cli/azure/cli/command_modules/vm/_validators.py | Adds validation for zone placement policy conflicts and zone allocation policy inputs. |
| src/azure-cli/azure/cli/command_modules/vm/_params.py | Exposes new CLI parameters for VMSS create/update. |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py | Adds live scenario tests for VMSS automatic zone placement and zone allocation policy updates. |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vmss_zone_placement_policy_with_include_zones.yaml | Recording for create with --zone-placement-policy Auto + --include-zones. |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vmss_zone_placement_policy_with_exclude_zones.yaml | Recording for create with --zone-placement-policy Auto + --exclude-zones. |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vmss_zone_placement_policy_with_max_instance_percent.yaml | Recording for create with max-instance-percent-per-zone policy enabled. |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vmss_zone_placement_policy_validation_overprovision_uniform.yaml | Recording for validation error when using zone placement policy with overprovisioning in Uniform mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vmss createaz vmss updateDescription
This PR Implement zone placement policy feature for VMSS, allowing the platform to automatically select optimal availability zones for deployments.
resolve: #31951
Testing Guide
azdev test VMSSAutomaticZonePlacementTest --liveazdev test VMSSUpdateZoneAllocationPolicyTest --liveHistory Notes
[Compute]
az vmss create[Compute]
az vmss updateThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.