Open
Conversation
ChristopherJMiller
left a comment
ChristopherJMiller
left a comment
There was a problem hiding this comment.
lgtm, if we wanted to be slightly more careful about it maybe we have a test case that uses a common tenant id, but it's probably fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support non-GUID tenants
Use Case
In Agency, we need start doing auth with multi-tenant client configs and non-tenant-GUID athorizations servers for MCP authentication in our proxy layer.
Since we're using azureauth here, we need to be able to pass in "common" as the tenant.
Testing
I've tested this change with the Azure CLI CLient ID, requesting a token for one of our new remote MCP Scopes for ADO on Mac and Windows (both arm64) and things are working as expected.