Instance discovery remains cloud local on known clouds#875
Open
Instance discovery remains cloud local on known clouds#875
Conversation
githubursul
reviewed
Feb 19, 2026
githubursul
left a comment
githubursul
left a comment
There was a problem hiding this comment.
Thank you for the changes. I made some recommendations.
tests/test_authority.py
Outdated
| continue | ||
| self._test_given_host_and_tenant(host, "common") | ||
|
|
||
| def test_new_sovereign_hosts_should_be_known_authorities(self): |
There was a problem hiding this comment.
This test is not durable. The set of "new" authorities will change with time. And I also don't see how to make it truly useful, since it tests that the values have been added to the map.
githubursul
approved these changes
Feb 19, 2026
githubursul
left a comment
githubursul
left a comment
There was a problem hiding this comment.
Thank you for the changes. I made some recommendations. Please address before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.