Add USE_VENDORED_JSON option (fixes #959)#1080
Conversation
Add a CMake option USE_VENDORED_JSON (default ON) so users can opt out of the bundled nlohmann::json and link against their own system-installed version, avoiding ODR violations when both versions coexist. - Add USE_VENDORED_JSON CMake option with find_package when OFF - Conditionally include vendored vs system json.hpp in 4 public headers - Add BTCPP_VENDORED_JSON compile definition to control #ifdef - Update install rules to exclude vendored json.hpp when OFF - Add find_dependency in Config.cmake.in for downstream consumers Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1080 +/- ##
=======================================
Coverage 65.90% 65.90%
=======================================
Files 225 225
Lines 12727 12727
Branches 1186 1186
=======================================
Hits 8388 8388
Misses 4289 4289
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Test plan
Generated with Claude Code