-
Notifications
You must be signed in to change notification settings - Fork 75
refactor: replace Hero CSS animations with Framer Motion . #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Hell1213
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced Hero section CSS animations with Framer Motion to reduce custom CSS and improve consistency with the rest of the app.
|
hey @its-me-abhishek pls take a look , PR is ready to review , I have implemented fix going with framer . |
its-me-abhishek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hell1213 this looks great! I think you forgot about the Homepage though. Moreover can you make this a separate component? maybe in utils, for common access, and better testing.
thanks , yeah i saw that apologies for that , I'll update the pr when its ready |
…Replaced CSS keyframe animations with Framer Motion in both Landing and Home page Hero components. Created a shared AnimatedGlow component in utils for better code reusability and testing.
7b66b5b to
6cd77b1
Compare
|
@its-me-abhishek pls check now , I have made a separate component in utils for common access as requested . |
Replaced CSS keyframe animations in the Hero section with Framer Motion. Removed 62 lines of custom CSS including keyframes and media queries from index.css. Implemented the same color-shifting glow effect using Framer Motion's animate prop with responsive sizing via Tailwind classes. Visual appearance remains identical.
Fixes: #450
Checklist
Additional Notes
This change consolidates animation logic by using the existing Framer Motion dependency instead of maintaining separate CSS animations. The glow effect behind the hero cards animates between pink and blue colors with the same timing and visual result as before.
Screencast.from.2026-02-06.00-29-13.mp4