Open
Conversation
Reduce cognetive complexity following PSR12 and Sonarqube
Converted legacy PHP array syntax from array(...) to short arrays [...] in:
TheWitness
requested changes
Feb 28, 2026
Member
TheWitness
left a comment
There was a problem hiding this comment.
This will not pass phpcsfixer test I don't think. Not that you have to change it, but why did you use the $create variable vs using the builtin db functions. It still works as it, just seemed unorthidox.
Beyond that it looks great. Test fails of course. We were supposed to use Pest for testing, yea I let Thomas slip one in through the cracks. But we have to fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings to the Cacti Audit plugin, focusing on code modernization, coding standards, and enhanced developer guidance. The most significant changes include enforcing PSR-12 coding standards, renaming functions to camelCase, updating documentation, improving JavaScript variable declarations, and adding PHPUnit test support.
Code Modernization and Standards
setup.phpfrom snake_case to camelCase to comply with PSR-12 standards, updated hook registrations accordingly, and added docblocks for better code clarity. [1] [2] [3] [4] [5] [6]auditConfigInsert,auditProcessPageData). [1] [2]Documentation and Developer Guidance
copilot-instructions.md,opilot-instructions.md) and consolidated guidance into a single, up-to-date file.README.mdwith instructions for running PHPUnit tests.Testing and CI Improvements
phpunit.xml.distconfiguration file and atestsdirectory to enable PHPUnit testing for the plugin.JavaScript Modernization
varwithletandconstinjs/functions.jsfor better variable scoping and code clarity. [1] [2] [3] [4]These changes collectively improve code quality, maintainability, and developer experience for the Cacti Audit plugin.