Skip to content

fix: 🐛 minimal react 19 and rsc support#756

Merged
punkbit merged 39 commits intomainfrom
fix/minimal-react-19-rsc-support
Feb 2, 2026
Merged

fix: 🐛 minimal react 19 and rsc support#756
punkbit merged 39 commits intomainfrom
fix/minimal-react-19-rsc-support

Conversation

@punkbit
Copy link
Collaborator

@punkbit punkbit commented Jan 20, 2026

Why?

TLDR; Click-UI fails to install, run or build on major React-like libraries, e.g. HyperDX, Nextjs, Vitejs latest. The PR provides a minimal set of changes to unblock the team.

The current/latest versions of click-ui, such as https://www.npmjs.com/package/@clickhouse/click-ui/v/0.0.250, break on the latest of Nextjs, Vitejs, any React >= 19 or RSC enabled builds. To mitigate it, this initial PR provides the minimal setup required for it to work in such environments, e.g. when installing the package, it should run in dev and build processes. It does NOT try to modify, replace, introduce or change breaking changes. At the time of writing, the library requires a browser runtime, being client-only. Separately, there'll be other PR to address other related concerns and expand on this initial PR, e.g. none interactive components shall render server-side.

A version is provided as:

https://www.npmjs.com/package/@clickhouse/click-ui/v/0.0.251-rc.17

npm i @clickhouse/click-ui@0.0.251-rc.17

How?

  • Make styled-components, as an external dependency
  • Opens brief support for hosting on React v19 projects retroactively
  • Declares as client library at entry point, preventing nested/subtree-related issues
  • Resolve some type issues

Demo?

Nextjs latest (v16), build/prod distribution output serving click-ui

demo-cui-nextjs-latest-build-output.mp4

HyperDX on dev, serving click-ui

demo-cui-nextjs-v16-latest.mp4

Vite latest, serving click-ui

demo-cui-vite-latest.mp4

Nextjs latest on dev

demo-cui-nextjs-v16-latest.mp4

@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
click-ui Ready Ready Preview, Comment Feb 2, 2026 10:51am

Request Review

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2026

CLA assistant check
All committers have signed the CLA.

@gjones
Copy link
Collaborator

gjones commented Jan 30, 2026

@kunalpanchal are you able to find some time in your AM to test this?

Copy link
Member

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in HyperDX here, and it works as expected.

LGTM! 🎉

@kunalpanchal
Copy link
Collaborator

Apart from the minor type error mentioned above, everything else looks and works fine on control-plane.

@punkbit
Copy link
Collaborator Author

punkbit commented Feb 2, 2026

Apart from the minor type error mentioned above, everything else looks and works fine on control-plane.

Just to avoid confusion, this is not shipping a type error! The change is a requirement due to a small deprecation in the context menu as described in the changeset here https://github.com/ClickHouse/click-ui/pull/756/changes#diff-801534275d6fc19b60543371f1055838e7d60942fa4005c3ab1623293e10fb7fR24

@punkbit punkbit merged commit 6b9c9d3 into main Feb 2, 2026
6 checks passed
@punkbit punkbit deleted the fix/minimal-react-19-rsc-support branch February 2, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants