Use genesis state to read network_id#1923
Merged
majecty merged 2 commits intoCodeChain-io:masterfrom Dec 17, 2019
Merged
Conversation
remagpie
requested changes
Dec 10, 2019
foriequal0
force-pushed
the
feature/genesis_network_id
branch
from
c0ee763 to
62e2829
Compare
remagpie
approved these changes
Dec 10, 2019
sgkim126
reviewed
Dec 11, 2019
Contributor
sgkim126
left a comment
sgkim126
left a comment
There was a problem hiding this comment.
Why do you use the genesis state instead of the latest state to read the network id?
They will be the same because changing network id is invalid for now.
Contributor
Author
|
This PR is cherry-picked from #1892. There were RPCs that try to read |
sgkim126
approved these changes
Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkIdhasn't been changed, and cannot be changed, and the effect of changes are unknown. It is easier to pin down to the genesis state for now.