Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 2 | improve_with_caches

[Nataliia74]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Improve code with caches 11

[cjyuan]

When total == 1 or len(coins) == 1 is true, the result may not be 1 if the last coin is not 1 (e.g. the initial list of coins given is different)

On the other hand, when len(coins) == 1, there is simple way to determine if the current total (any value) can be made by the coin value.

[cjyuan]

Array creation is a relatively costly operation.

From line 41, we know coins can only be one of the following 9 arrays:

[200, 100, 50, 20, 10, 5, 2, 1]
[100, 50, 20, 10, 5, 2, 1]
[50, 20, 10, 5, 2, 1]
...
[1]
[]

We could further improve the performance if we can

• avoid repeatedly creating the same sub-arrays at line 41 (e.g. use another cache), and
• create key as (total, a_unique_integer_identifying_the_subarray) instead of as (total, tuple of coins)
  • There are only a small number of different subarrays. We can easily assign each subarray a unique integer.