London | 26-ITP-January | Dagim Daniel | Sprint 2 | Form-control#1181
London | 26-ITP-January | Dagim Daniel | Sprint 2 | Form-control#1181Dagim-Daniel wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Dagim-Daniel
added
Needs Review
cjyuan
added
Review in progress
|
I expected In the PR description, you should include a section to describe what you have changed in this PR. It should look something like this: ChangelistShort description of the changes you have made ... |
cjyuan
added
Reviewed
Dagim-Daniel
added
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
According to https://validator.w3.org/, there are warnings in your code. Can you fix them?
| --paper: oklch(7 0 0); | ||
| --ink: color-mix(in oklab, var(--color) 5%, black); | ||
| --font: 100%/1.5 system-ui; | ||
| --space: clamp(6px, 6px + 2vw, 15px); | ||
| --line: 1px solid; | ||
| --container: 1280px; |
There was a problem hiding this comment.
Can you delete any unused custom properties to keep the code clean?
| <fieldset> | ||
| <legend>Customer Information</legend> | ||
| <label for="name">Name:*</label> | ||
| <input type="text" id="name" name="name" required pattern="[A-za-z/s]{2,50}"/> |
There was a problem hiding this comment.
Can you explain what this regular expression, [A-za-z/s]{2,50}, mean? That is, what kind of strings are acceptable? Have you tested the input field to see if the form accepts/rejects the value you expect?
Currently, when an input is rejected, the user is not given any explanation as to why.
Could you make the form more accessible by providing clear feedback so users can understand why their input was rejected?
cjyuan
removed
the
Needs Review
|
Your PR description is missing a |
2 participants
Learners, PR Template
Self checklist