London | 26-ITP-January | Rawan Almutairi | Sprint 2 | Form-control#1194
London | 26-ITP-January | Rawan Almutairi | Sprint 2 | Form-control#1194Rawan-Al0-0 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
Rawan-Al0-0
changed the title
This comment has been minimized.
This comment has been minimized.
Rawan-Al0-0
added
Needs Review
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
Your PR Description is missing a "Changelist" section. Can you restore the Changelist section and give a brief description of what you have changed on this branch?
| <input type="checkbox" id="color1" name="color1" style="font-size: 23px; margin-left: 12px;" value="Red"><br><br> | ||
| <label for="color2"> Blue</label> |
There was a problem hiding this comment.
-
Can you keep all the CSS code in an external CSS file?
Inline CSS makes HTML code harder to read and maintain. -
Is "checkbox" an appropriate input type for asking the user to select exactly one color?
| <P>Select a size for your t-shirt:</p> | ||
| <input list="size" name="sie"> | ||
| <datalist id="size"> |
There was a problem hiding this comment.
Code on this file is not yet properly indented.
Consider using VSCode's "Format Document" feature (or any other software tool) to format the code for better readability and consistency. To use the VSCode's feature, right-click inside the code editor and select the option.
| <option value="xs"></option> | ||
| <option value="s"></option> | ||
| <option value="m"></option> | ||
| <option value="l"></option> | ||
| <option value="xl"></option> | ||
|
|
||
| </datalist> |
There was a problem hiding this comment.
If this code are not needed, it is better to delete them to keep the code clean.
| <input type="radio" id="xs" name="size" style="min-width:24px; min-height:24px; padding:8px 12px; margin:4px;font-size: 24px; margin-left: 20px;" value="XS"> | ||
| <label for="xs">XS</label><br> | ||
| <input type="radio" id="s" name="size" style="min-width:44px; min-height:24px; padding: 8px 12px; margin:4px;font-size: 24px; margin-left: 10px;" value="S"> | ||
| <label for="s">S</label><br> | ||
| <input type="radio" id="m" name="size" style="min-width:44px; min-height:24px; padding: 8px 12px; margin:4px;font-size: 24px; margin-left: 10px;" value="M"> | ||
| <label for="m">M</label><br> | ||
| <input type="radio" id="l" name="size" style="min-width:44px; min-height:24px; padding: 8px 12px; margin:4px;font-size: 24px; margin-left: 10px;"value="L"> | ||
| <label for="l">L</label><br> | ||
| <input type="radio" id="xl" name="size" style="min-width:44px; min-height:24px; padding: 8px 12px; margin:4px;font-size: 24px; margin-left: 10px;"value="XL"> | ||
| <label for="xl">XL</label><br> | ||
|
|
There was a problem hiding this comment.
This implementation does not yet meet the requirement specified in the README.md file
| <img src="t-shirt1.jpg" alt="background image" style="height: 100%; | ||
| text-align: center; position:fixed; left: 30%; top: 0;"> |
There was a problem hiding this comment.
What is this image? Currently it is showing up as a corrupted icon on the page.
cjyuan
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Questions
I have no questions.