London | 26-ITP-Feb | Shuheda Begum | Sprint 3 | Implement and Rewrite Test#1064
Closed
codebyshay wants to merge 26 commits intoCodeYourFuture:mainfrom
Closed
London | 26-ITP-Feb | Shuheda Begum | Sprint 3 | Implement and Rewrite Test#1064codebyshay wants to merge 26 commits intoCodeYourFuture:mainfrom
codebyshay wants to merge 26 commits intoCodeYourFuture:mainfrom
Conversation
Questions Answered
Fixed code and tested.
Added my prediction
Code amended and working.
Explanation of syntax error and new code
Prediction and explanation
New Code
Prediction and explanation
New code updated
Predicted, anded explanation and fixed code.
Fixed spelling
Made notes and built a code to calculate bmi.
Made notes for code requirements. Used MDN. Developed code that runs.
Located original code Made notes Worked on a code
Questions answered
Code fixed. Tested with various times.
Used the notes to write 'if' statements that reflect the requirements. e.g. "Acute angle" for angles greater than 0° and less than 90° becomes, if (angle > 0 && angle < 90) {
return "Acute angle";
I wrote tests to cover all cases, including boundary and invalid.
Defined proper fractions and implemented isProperFraction function.
Add comprehensive tests for isProperFraction including edge cases
Add getCardValue logic for ranks and suits.
Add comprehensive tests including error handling for invalid cards
Add comprehensive Jest tests covering all angle cases.
Add comprehensive Jest tests covering positive, negative, zero, and edge cases for isProperFraction.
Add Jest tests for Ace, number, face, and invalid cards for getCardValue.
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implement and tested
Questions
No questions