London | 26-ITP-January | Damian Dunkley | Sprint 1 | coursework/sprint-1 by DamianDL · Pull Request #949 · CodeYourFuture/Module-Structuring-and-Testing-Data

DamianDL · 2026-02-10T11:19:40Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have completed the three mandatory exercises in sprint -1; the 4 exercises in 1-key-exercises, explained and corrected the 4 errors in 2-mandatory-errors and explained how the code works in 3-mandatory-interpret. I have not yet completed the 4-stretch-explore exercises, but understand that this is not critical for this PR.

I have used the reference documentation;
https://www.google.com/search?q=get+first+character+of+string+mdn
https://www.google.com/search?q=slice+mdn
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Arithmetic_Operators

Questions

…ed as text

…nd explanation included as text

…included as text

…ncluded as text

…ation/answers included as text

jennethydyrova

Hi @DamianDL. Solid work! I left couple of comments as a stretch to explore how you could improve your code. Two comments in Sprint-1/3-mandatory-interpret/2-time-format.js file require changes.

jennethydyrova · 2026-02-20T13:57:11Z

Sprint-1/1-key-exercises/3-paths.js

-const dir = ;
-const ext = ;
+const dir = filePath.slice(0, lastSlashIndex);
+const ext = filePath.slice(lastSlashIndex + 1).split(".").pop();


You could do this slightly simpler. Do you already have a variable that does filePath.slice(lastSlashIndex + 1)?

jennethydyrova · 2026-02-20T14:00:09Z

Sprint-1/2-mandatory-errors/0.js

@@ -1,2 +1,4 @@
-This is just an instruction for the first activity - but it is just for human consumption
-We don't want the computer to run these 2 lines - how can we solve this problem?
+//This is just an instruction for the first activity - but it is just for human consumption


I am a little bit nitpicking here but we leave a space between // and your comment. That would be // Foo

jennethydyrova · 2026-02-20T14:04:32Z

Sprint-1/2-mandatory-errors/0.js

-This is just an instruction for the first activity - but it is just for human consumption
-We don't want the computer to run these 2 lines - how can we solve this problem?
+//This is just an instruction for the first activity - but it is just for human consumption
+//We don't want the computer to run these 2 lines - how can we solve this problem?


Another, more conventional way to write multi-line comments is shown here: https://developer.mozilla.org/en-US/docs/Web/CSS/Guides/Syntax/Comments#examples.

That said, this approach works as well.

jennethydyrova · 2026-02-20T14:20:48Z

Sprint-1/3-mandatory-interpret/2-time-format.js

-
+// There are 6 variable declarations in this program. They are: movieLength, remainingSeconds, totalMinutes, remainingMinutes, totalHours, and result.
 // b) How many function calls are there?
+// There are 2 function calls in this program. They are: the template literal function call when assigning a value to the result variable (line 9) and the console.log function call on  line 10.


Line 9 isn’t a function call, it’s just a template literal creating a string using backticks and ${} interpolation. No function is being executed there because there are no () parentheses.

jennethydyrova · 2026-02-20T14:27:20Z

Sprint-1/3-mandatory-interpret/2-time-format.js


 // e) What do you think the variable result represents? Can you think of a better name for this variable?

+// The variable result is the length of the movie in hours, minutes, and seconds. A better name for this variable could be movieDurationhms, as it more clearly indicates that it is the duration of the movie in hours, minutes, and seconds.


Your suggestion for variable name movieDurationhms is good but to follow the camelCase rule of naming variables, it would need to be movieDurationHms. I would suggest to simplify it to movieDuration as Hms is a bit cryptic and not very clear for a code reader.

…paths.js and to 2-mandatory-errors/0.js

jennethydyrova · 2026-02-23T10:27:01Z

Good work!

DamianDL · 2026-02-25T12:23:00Z

Hi @jennethydyrova. Thanks for reviewing my PR again. I am unclear what still needs correcting/updating/changing for this to be completed? Please can you help me understand what is outstanding? Thanks Damian

jennethydyrova · 2026-02-25T12:42:02Z

Hi @DamianDL! Nope, I forgot to change the label. It should be all good now

DamianDL · 2026-02-26T09:34:54Z

Thanks @jennethydyrova, great news.

DamianDL added 12 commits February 9, 2026 10:59

Key exercises 1-3 completed

36a00cc

Replace 4-random.js with version from main

9fe6f44

Answer to 4-random.js included as text

fb41b78

Answer to 2-mandatory-errors/0.js included as text

d9ecdf5

Answer to 2-mandatory-errors/1.js included as text

aa7d600

Answer to 2-mandatory-errors/2.js included as text

ad67e7b

Answer to 2-mandatory-errors/3.js code updated and explanation includ…

e4e3d07

…ed as text

Answer to 2-mandatory-errors/4.js code updated and explanation includ…

6b83e27

…ed as text

Answer to 3-mandatory-interpret/1-percentage-change.js code updated a…

4004b30

…nd explanation included as text

Answer to 3-mandatory-interpret/2-time-format.js explanation/answers …

cb505df

…included as text

Answer to 3-mandatory-interpret/ 3-to-pounds.js explanation/answers i…

630fa14

…ncluded as text

Updated answer to 2-mandatory-errors/1.js to make code works. Eexplan…

54784c1

…ation/answers included as text

DamianDL added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 10, 2026

Merge branch 'main' into coursework/sprint-1

1304d1b

MorganDavid added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 14, 2026

DamianDL added 2 commits February 17, 2026 11:29

changes to Sprint1 updated

28c854e

changes to Sprint1 updated

6c190f1

DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 19, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

This comment has been minimized.

Sign in to view

DamianDL added 4 commits February 19, 2026 09:24

removed /prep directory

8db0f90

removed /Sprint-2 directory

7606c3b

Restored Sprint-2 from Main

1956015

remopved email file

6e86920

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

jennethydyrova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 20, 2026

jennethydyrova reviewed Feb 20, 2026

View reviewed changes

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 20, 2026

DamianDL added 2 commits February 21, 2026 15:37

updates in response to PR. simplified variables to 1-key-exercises/3-…

4a6b0af

…paths.js and to 2-mandatory-errors/0.js

updates in response to PR. 3-mandatory-interpret/2-time-format.js

8265d41

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 23, 2026

jennethydyrova added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 25, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

London | 26-ITP-January | Damian Dunkley | Sprint 1 | coursework/sprint-1#949

London | 26-ITP-January | Damian Dunkley | Sprint 1 | coursework/sprint-1#949
DamianDL wants to merge 21 commits intoCodeYourFuture:mainfrom
DamianDL:coursework/sprint-1

DamianDL commented Feb 10, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jennethydyrova left a comment

Uh oh!

jennethydyrova Feb 20, 2026

Uh oh!

jennethydyrova Feb 20, 2026

Uh oh!

jennethydyrova Feb 20, 2026

Uh oh!

jennethydyrova Feb 20, 2026

Uh oh!

jennethydyrova Feb 20, 2026

Uh oh!

jennethydyrova commented Feb 23, 2026

Uh oh!

DamianDL commented Feb 25, 2026

Uh oh!

jennethydyrova commented Feb 25, 2026

Uh oh!

DamianDL commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		// e) What do you think the variable result represents? Can you think of a better name for this variable?

		// The variable result is the length of the movie in hours, minutes, and seconds. A better name for this variable could be movieDurationhms, as it more clearly indicates that it is the duration of the movie in hours, minutes, and seconds.

Uh oh!

Conversation

DamianDL commented Feb 10, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jennethydyrova left a comment

Choose a reason for hiding this comment

Uh oh!

jennethydyrova Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

jennethydyrova Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

jennethydyrova Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

jennethydyrova Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

jennethydyrova Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

jennethydyrova commented Feb 23, 2026

Uh oh!

DamianDL commented Feb 25, 2026

Uh oh!

jennethydyrova commented Feb 25, 2026

Uh oh!

DamianDL commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants