Conversation
…rity-fix [staging] Chore/1102 form data security fix
|
Although I have approved but I have called @pedroguima to grant the admin privilege to the devops team otherwise i can't unlock circleci-check on the branch |
|
These are @susanssky's own changes from #199, right? So surely someone else should be reviewing them, otherwise we're achieving none of the goals of code review. |
of course. we agreed that dev/ops team will review as we need minimum two reviewers anyway |
There was a problem hiding this comment.
Wondering if details such as bucket, distribution, region, role, and url can be saved as variables and then referenced in the pipeline that way instead of directly.
There was a problem hiding this comment.
Wondering if details such as
bucket,distribution,region,role, andurlcan be saved as variables and then referenced in the pipeline that way instead of directly.
Honestly, if I’m the person updating the workflow, I really don’t want to see var.SUBDOMAIN every time and then have to click on Settings → Environment variables manually just to check the real value.
Also, the DevOps team doesn’t have admin rights in the forms repo or the application process repo.(I have called Pedro about it)
This is a:
Description
replacing circleCi yml with github workflows
Migrate to Github actions from CircleCI because we don't need CircleCI
Use IAM role than IAM user
It’s only after the PR is merged that we can check if the qa job (on CI.yml) and build-and-deploy (on deploy.yml) works.
Links
Author checklist
qafrom a branch named<category>/<name>, e.g.feature/edit-spaceshipsorbugfix/restore-oxygen