Skip to content

Conversation

@LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Feb 4, 2026

Overview

  • Add directional property configs for width, minWidth, maxWidth, height, minHeight, maxHeight (e.g., width → inlineSize) and direction
  • Add direction props to layout config
  • Update docs related to layout and typography
  • Update tests to cover both logical and physical property modes

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1516
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to story X
  2. Do something
  3. Do that something in dark mode
  4. Check it with VO
  5. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@LinKCoding LinKCoding changed the base branch from main to kl-gmt-1508v2-margin-padding February 4, 2026 19:52
@nx-cloud
Copy link

nx-cloud bot commented Feb 4, 2026

View your CI Pipeline Execution ↗ for commit 92998dd


☁️ Nx Cloud last updated this comment at 2026-02-09 21:44:26 UTC

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.03%. Comparing base (f3d0b83) to head (92998dd).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           kl-gmt-1451-logical-props    #3259   +/-   ##
==========================================================
  Coverage                      82.03%   82.03%           
==========================================================
  Files                             75       75           
  Lines                           1414     1414           
  Branches                         465      465           
==========================================================
  Hits                            1160     1160           
  Misses                           251      251           
  Partials                           3        3           
Flag Coverage Δ
pull-request 82.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LinKCoding LinKCoding changed the title Kl gmt 1516 gamut layout typography feat: Add typography and layout related logical props Feb 5, 2026
Base automatically changed from kl-gmt-1508v2-margin-padding to kl-gmt-1451-logical-props February 6, 2026 15:55
@LinKCoding LinKCoding mentioned this pull request Feb 6, 2026
6 tasks
@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/gamut@68.1.0-alpha.e6658d.0
@codecademy/gamut-icons@9.56.0-alpha.e6658d.0
@codecademy/gamut-illustrations@0.58.3-alpha.e6658d.0
@codecademy/gamut-kit@0.7.0-alpha.e6658d.0
@codecademy/gamut-patterns@0.10.22-alpha.e6658d.0
@codecademy/gamut-styles@17.12.0-alpha.e6658d.0
@codecademy/gamut-tests@5.2.20-alpha.e6658d.0
@codecademy/styleguide@79.2.0-alpha.e6658d.0
@codecademy/variance@0.26.0-alpha.e6658d.0

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants