Skip to content

Kl gmt 1516 layout typography revert#3266

Closed
LinKCoding wants to merge 37 commits intokl-gmt-1451-logical-props--jh-revertfrom
kl-gmt-1516-layout-typography-revert
Closed

Kl gmt 1516 layout typography revert#3266
LinKCoding wants to merge 37 commits intokl-gmt-1451-logical-props--jh-revertfrom
kl-gmt-1516-layout-typography-revert

Conversation

@LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Feb 12, 2026

Overview

  • Add directional property configs for width, minWidth, maxWidth, height, minHeight, maxHeight (e.g., width → inlineSize) and direction
  • Add direction props to layout config
  • Update docs related to layout and typography
  • Update tests to cover both logical and physical property modes

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1516
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to Props/Layout /foundations-system-props-layout--docs page
  2. Read over the new info and check that it makes sense
  3. Check that the new Direction button works and changes from LTR to RTL and vice versa
  4. ...
  5. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

* working PoC

* fix build and format

* lint fixes

* some more refactoring

* fix existing test failures

* add test for getPropertyMode

* updated gamutprovider to include useLogicalProperties

* fix failiing tests

* more test fixes

* formatted

* add logicalprops switcher to toolbar

* updated  shorthand in margin related CSS properties

* fix linting issue re: physical

* update docs to show logical prop updates to margin related props

* updated padding too

* updated Usage Guide and clean up

* add new file to explain logical and physical properties

* update docs for readibility

* formatted and cleaned up

* fix tests and edit MockGamutProvider to use useLogicalProperties

* temp fix for test failure

* start on border related logical props

* updated more border props

* formatted

* added border color props

* grammar

* formatted
@nx-cloud
Copy link

nx-cloud bot commented Feb 12, 2026

View your CI Pipeline Execution ↗ for commit 6d57a99


☁️ Nx Cloud last updated this comment at 2026-02-12 19:42:25 UTC

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.15%. Comparing base (28d8599) to head (6d57a99).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                           Coverage Diff                            @@
##           kl-gmt-1451-logical-props--jh-revert    #3266      +/-   ##
========================================================================
+ Coverage                                 89.09%   89.15%   +0.06%     
========================================================================
  Files                                       236      238       +2     
  Lines                                      4309     4315       +6     
  Branches                                   1447     1447              
========================================================================
+ Hits                                       3839     3847       +8     
+ Misses                                      462      460       -2     
  Partials                                      8        8              
Flag Coverage Δ
pull-request 89.15% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/gamut@68.0.1-alpha.097b76.0
@codecademy/gamut-icons@9.54.3-alpha.097b76.0
@codecademy/gamut-illustrations@0.58.3-alpha.097b76.0
@codecademy/gamut-kit@0.6.580-alpha.097b76.0
@codecademy/gamut-patterns@0.10.22-alpha.097b76.0
@codecademy/gamut-styles@17.12.0-alpha.097b76.0
@codecademy/gamut-tests@5.2.20-alpha.097b76.0
@codecademy/styleguide@79.2.0-alpha.097b76.0
@codecademy/variance@0.25.3-alpha.097b76.0

@github-actions
Copy link
Contributor

@LinKCoding LinKCoding closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants