TST: Try putting fortran in own directory#66
Merged
rstoneback merged 30 commits intov1.1.0-RCfrom Apr 5, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #(issue)
Started this looking for ways to get coverage working. First thought was that it may be related to a difference in file organization between OMMBV and apexpy. Further investigation revealed that it was primarily an issue with how the coveralls pytest command was constructed. Coveralls coverage reporting is now driven by the source files, not test files, and reporting to the coveralls website is working again!
So the Fortran files don't actually need to be in their own directory but here we are now.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Manual interactions with coveralls webpage as well as the unit tests run by GitHub actions.
Checklist:
develop(notmaster) branchCHANGELOG.md, summarizing the changes