feat: deployment config & unified service name#3879
Merged
Conversation
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Snowflake connectors service to use the new
snowflake-connectors-workernaming convention across environment configuration, Docker, and service definitions. The changes ensure consistency in naming and configuration, which helps clarify the role of the worker service and prevents confusion with previous connector naming.Naming and configuration updates:
snowflake-connectorstosnowflake-connectors-workerin environment variables, Dockerfile paths, and service names within thepackage.jsonscripts for the Snowflake connectors app.snowflake-connectors.yamltosnowflake-connectors-worker.yaml, and updated service names and hostnames to usesnowflake-connectors-workerinstead ofsnowflake-connectors. [1] [2] [3]snowflake-connectors-worker.envspecifying the Dockerfile, context, repository, and services for the worker.Note
Low Risk
Config-only renaming for build/compose and runtime env vars; primary risk is deployment/runtime breakage if any external references still expect the old
snowflake-connectorsservice name.Overview
Standardizes the Snowflake connectors deployment to the
snowflake-connectors-workerservice name across build and runtime configuration.Adds a new build env config (
scripts/builders/snowflake-connectors-worker.env) and updates the compose definition (scripts/services/snowflake-connectors-worker.yaml) to use the worker-specific Dockerfile and service/hostname names. Updatesservices/apps/snowflake_connectors/package.jsonscripts sostart/debug andtrigger-exportrun withSERVICE=snowflake-connectors-worker.Written by Cursor Bugbot for commit f518ce1. This will update automatically on new commits. Configure here.