vector<int32_t> and vector<int16_t>#4676
Merged
myk002 merged 2 commits intoDFHack:developfrom Jun 6, 2024
Merged
Conversation
this makes identity traits for these two specializations available in plugins with this change, the `stl_vector_identity` template will be visible to plugins, but the identity objects _themselves_ will not (except for `vector<int32_t>` and `vector<int16_t>`) so any attempt to actually use a `vector` other than one of these two types or of a pointer type (which is covered elsewhere by the `vector<T*>` specialization which is exported) will result in linkage errors
myk002
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this makes identity traits for these two specializations available in plugins
with this change, the
stl_vector_identitytemplate will be visible to plugins, but the identity objects themselves will not (except forvector<int32_t>andvector<int16_t>) so any attempt to actually use avectorother than one of these two types or of a pointer type (which is covered elsewhere by thevector<T*>specialization which is exported) will result in linkage errorsthis is mainly intended to enable merging #4632 without #4591, since i don't think i want to pursue #4591 at this time