Add toolbar button for gui/design#1425
Open
realSquidCoder wants to merge 6 commits intoDFHack:masterfrom
Open
Conversation
Contributor
|
If you try a minimum-size DF window (912x552px, 114x46 UI tiles@8x12px), I think you will see that there are only 7 unused-by-DF columns between the left and "center" toolbars. So the sitemap button and this button will not both fit in a minimum size interface area. Not sure what might be best
|
myk002
reviewed
Apr 3, 2025
Comment on lines
+1648
to
+1650
| function DesignToolbarOverlay:onInput(keys) | ||
| return DesignToolbarOverlay.super.onInput(self, keys) | ||
| end |
Member
There was a problem hiding this comment.
this function is a noop and can be removed
| DesignToolbarOverlay = defclass(DesignToolbarOverlay, overlay.OverlayWidget) | ||
| DesignToolbarOverlay.ATTRS{ | ||
| desc='Adds a button to the toolbar at the bottom of the screen for launching gui/design.', | ||
| default_pos={x=50, y=-1}, |
Member
There was a problem hiding this comment.
This position isn't going to work:
mayyybe here in the dig toolbar?
though that bar is already quite crowded..
another option could be moving the sitemap button over one tile and placing this next to it, but that might also be too crowded. The space next to the sitemap button is there for a reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after DFHack/dfhack#5365
Also wait until I can make this use this PR's code library to make it work cleanly