Merged
Conversation
Member
Author
|
@mlarraz this should fix the error you reported, could you please test this in your project? |
pat
approved these changes
May 15, 2025
Contributor
pat
left a comment
pat
left a comment
There was a problem hiding this comment.
Looks good to me! Appreciate the quick patch :)
|
Yes that appears to have fixed it for me |
|
Can we have a new version with this patch please? |
etagwerker
added a commit
that referenced
this pull request
Jul 7, 2025
etagwerker
force-pushed
the
fixes-120-pre-count-truncate-with-options
branch
from
e289fab to
0d548f9
Compare
|
I also would like to chime in for the value of getting this patch merged and released. We have no path to Rails 7.2 without a patch or custom workaround. I see the tests are failings -- is that what is blocking release of this? Is there way for us to support this effort? |
* Fixes #120 * Add docker configuration for development This makes it easier to run the test suite in your local dev environment * Add a development section for contributors This should make it easier for people to set up the library and run the test suite within Docker * Added ruby service to make it easier to get started with your contribution * Update password to match Docker configuration * Removed outdated docker-compose file * Use older mysql to avoid trilogy error, fix docker compose and instructions, mount code for easier development * Update readme to point to CONTRIBUTE.md file * Run ./bin/setup so that we have the config file in place for tests * Relax dependency * Add a line about the Docker + DX change --------- Co-authored-by: Ariel Juodziukynas <arieljuod@gmail.com>
For Rails >= 7.2, this library gets a connection via `#lease_connection`. But it never releases the connection. Release the connection back to the pool after `#clean`-ing. Rails >= 7.2 does connection health checks / reconnect on connection checkout. If the connection is never checked back into the pool, it will never get "repaired", which makes testing database connection issues tricky.
Member
Author
|
v2.2.2 has been released with this fix: https://rubygems.org/gems/database_cleaner-active_record/versions/2.2.2 |
|
Greatly appreciated @etagwerker !!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
This PR fixes #120 with something that was missed on #118
Please check it out.
Thanks!