Use safe placholder atlas name if atlas XML not found#734
Open
Use safe placholder atlas name if atlas XML not found#734
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #734 +/- ##
==========================================
- Coverage 46.66% 46.65% -0.01%
==========================================
Files 91 91
Lines 9604 9606 +2
Branches 1254 1255 +1
==========================================
Hits 4482 4482
- Misses 4910 4911 +1
- Partials 212 213 +1 🚀 New features to boost your workflow:
|
d-j-hatton
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search for an atlas XML file currently fails if no search results were returned for the atlas:
src/murfey/client/context.py, L97-99
This PR adjusts that logic so that it proceeds with the post to the backend server with the minimum amount of informaiton present and safe-ish placeholder name for the atlas.