Skip to content

Register CLEM colours#739

Open
tieneupin wants to merge 19 commits intomainfrom
register-clem-colours
Open

Register CLEM colours#739
tieneupin wants to merge 19 commits intomainfrom
register-clem-colours

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Feb 6, 2026

The recently released version of ispyb-api includes new columns in the Atlas and GridSquare tables that can be used to keep track of the data collection mode used for, and the colour channels present in, a particular dataset. This PR adds optional logic to the Atlas and GridSquare insertion/update functions to register the colour channel information and collection mode associated with the CLEM workflow.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 87.93103% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.13%. Comparing base (8739a6c) to head (d121b9e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   46.66%   46.13%   -0.54%     
==========================================
  Files          91       91              
  Lines        9604     9862     +258     
  Branches     1254     1334      +80     
==========================================
+ Hits         4482     4550      +68     
- Misses       4910     5076     +166     
- Partials      212      236      +24     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin force-pushed the register-clem-colours branch from f109365 to 095520d Compare February 6, 2026 07:27
@tieneupin tieneupin self-assigned this Feb 6, 2026
@tieneupin tieneupin added server Relates to the server component cryo-clem Part of the cryo-CLEM pipeline extension labels Feb 6, 2026
Copy link
Contributor

@d-j-hatton d-j-hatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Looking cool in PATo so good to progress this

…of just activating the ones it receives; fixed colour flag and collection mode insertion logic for the Atlas
…rival of message, then translate it across to Atlas and GridSquare tables in ISPyB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cryo-clem Part of the cryo-CLEM pipeline extension server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants