Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
- Coverage 46.66% 46.13% -0.54%
==========================================
Files 91 91
Lines 9604 9862 +258
Branches 1254 1334 +80
==========================================
+ Hits 4482 4550 +68
- Misses 4910 5076 +166
- Partials 212 236 +24 🚀 New features to boost your workflow:
|
… the Atlas and GridSquare tables in ISPyB for the CLEM workflow
…ng the 'get' call
f109365 to
095520d
Compare
d-j-hatton
reviewed
Feb 6, 2026
d-j-hatton
approved these changes
Feb 6, 2026
Contributor
d-j-hatton
left a comment
There was a problem hiding this comment.
Looks good. Looking cool in PATo so good to progress this
…of just activating the ones it receives; fixed colour flag and collection mode insertion logic for the Atlas
…e used for dataset
…rival of message, then translate it across to Atlas and GridSquare tables in ISPyB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently released version of
ispyb-apiincludes new columns in the Atlas and GridSquare tables that can be used to keep track of the data collection mode used for, and the colour channels present in, a particular dataset. This PR adds optional logic to the Atlas and GridSquare insertion/update functions to register the colour channel information and collection mode associated with the CLEM workflow.