added check access token validity before refresh#309
Open
fbarresi wants to merge 1 commit intoDuendeSoftware:mainfrom
Open
added check access token validity before refresh#309fbarresi wants to merge 1 commit intoDuendeSoftware:mainfrom
fbarresi wants to merge 1 commit intoDuendeSoftware:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use a
RefreshTokenDelegatingHandlerto gather a bearer token from a refresh token in my application.However, I noticed in my code that reusing the handler (rather than instantiating it again) leads to error replies due to the use of an expired token.
This seems to be because the validity of the token after a refresh is never evaluated in successive usages, and the
RefreshTokenDelegatingHandlerattempts to use the expired token anyway.In general, I think evaluating token expiration (when known) should be a common function of this handler. Additionally, reusing the handler instead of recreating it would minimise the number of requests to the IDP.