fix: add license-expression case to get_license#124
Open
mckornfield wants to merge 1 commit intoFHPythonUtils:masterfrom
Open
fix: add license-expression case to get_license#124mckornfield wants to merge 1 commit intoFHPythonUtils:masterfrom
mckornfield wants to merge 1 commit intoFHPythonUtils:masterfrom
Conversation
mckornfield
force-pushed
the
mck/fix-license-expression-case
branch
from
2ac0a6d to
d18d16a
Compare
mckornfield
changed the title
Author
|
@FredHappyface I couldn't see a way to tag you for review other than a comment. Let me know if there's a more proper way I should ask for feedback (or how busy you are, etc.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of This Pull Request
Please check the relevant option by placing an "X" inside the brackets:
Overview of Changes
Provide a concise overview of the changes made in this pull request
Related Issue
Fixes #121
Reviewer Focus
Should be relatively straight forward, didn't see a great way to add a test without importing
another package but I can do so