Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a BREAKING change. The following open issues have been resolved:
mayhem_runrule was invoked withbazel build, which A. was counterintuitive and B. prevented users from running multiple times as Bazel would not kick off a run if no files were modified (because it considered it a build output). Now,mayhem_runrules are invoked withbazel run. This is accomplished using runfiles, which is now necessary to enable in.bazelrcwithcommon --enable_runfiles.my_target.sh.runfiles/_main)image_dependencyfor themayhem_runrule, so that the output of a call tooci_pushcan be depended on prior to running Mayhem.mayhem waitcommand could be duplicated, causing the command to fail.rules_shellandrules_ccas dependencies as they are no longer part of Bazel core.How to migrate to
0.8.4:mayhem_run()rule so that they callbazel runinstead ofbazel build(note:bazel buildwill technically still work, but it doesn't do anything other than generate the run script).common --enable_runfiles(orcommon:windows --enable_runfilesif you are using platform-specific configuration).junitorsariffiles from the bazel-rules_mayhem root directory, you will now want to grab these from the target runfiles directory.