docs: improve ESP32 flashing guide clarity and fix typos#16
Open
jjsilva510 wants to merge 2 commits intoFreedomLabNYC:mainfrom
Open
docs: improve ESP32 flashing guide clarity and fix typos#16jjsilva510 wants to merge 2 commits intoFreedomLabNYC:mainfrom
jjsilva510 wants to merge 2 commits intoFreedomLabNYC:mainfrom
Conversation
Contributor
jjsilva510
commented
Oct 28, 2025
jjsilva510
commented
- Improve sentence structure and readability
- Clarify COM port selection instructions
- Enhance image descriptions
- Fix spelling errors (splash, ensures) - Improve sentence structure and readability - Add proper punctuation and consistent capitalization - Clarify COM port selection instructions - Enhance image descriptions
docs/topics/bitcoin-hardware-wallet/00-beginners-hardware-wallet/lesson.md
Show resolved
Hide resolved
| 6. That's it! A progress bar should show up, and when it's finished, you're ready to set it up. | ||
|
|
||
| 7. The LilyGo T-Display should show a quick splash screen that says "Jade DIY", after which it should display the following screen: | ||
|  |
Member
There was a problem hiding this comment.
same thing with this img. needs to be in the PR. maybe we should start using GIT LFS but that's for a different conversation
Member
There was a problem hiding this comment.
in the future, let’s avoid spaces in file names. i’m not sure this will be linked properly
|
|
||
| * An existing Lightning Wallet that you can use to fund your LNbits account with. | ||
| * A Mobile Phone with NFC support (Only actually works with android). | ||
| * A BoltRing or NFC424 enabled device that has not been set up yet (or has been [wiped](./#)). |
Member
There was a problem hiding this comment.
i’m not sure where this link goes. is this correct?
|
|
||
| ## Step 1 - Install Bolt Card Creator | ||
|
|
||
| If you have an **Android** phone install the **Bolt Card NFC Card Creator App** from Google Play. If you are using an **iPhone** install the **Boltcard NFC Programmer** from the App Store. This doesn't really work well with iPhone. |
Member
There was a problem hiding this comment.
we should link to these apps
|
|
||
| 1. Select the **Advanced** tab at the bottom of the start screen of the Bolt Card Creator App. | ||
| 2. Select the **Read NFC** tab on the stacked menu. | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
extra new line
| Smartphones have their NFC antenna in different places. Usually, it is in the upper third of the back of the phone. While scanning the BoltRing, pay attention to the position the app detects the BoltRing. Knowing the antenna position will give you more confidence when writing the configuration to the BoltRing later. | ||
|
|
||
| > **Error: This NFC card has not been formatted.** | ||
| > If you get this error, you can use the **NXP TagWriter App** to erase and format your tag as NDEF. |
|
|
||
| 1. Click on **Manage Extensions** in the left menu. | ||
| 2. Click **ENABLE** on the **Bolt Cards** tile. | ||
|
|
Member
There was a problem hiding this comment.
ui screenshots would be great here. there’s also an extra newline above 3
| * Click **CREATE CARD**. | ||
|
|
||
|
|
||
| 3. After clicking **CREATE CARD**, you should see the card service created. Click the **QR Code** in the first column of the list to show the QR code you need in the next step. |
Member
There was a problem hiding this comment.
let’s remove extra lines and add ui screenshots
| 3. Scan the **QR code** from the LNbits popup (from Step 5) using the app's QR code scanner. | ||
| 4. The app will show "Bolt Card Service URL received" and populate the write fields. | ||
| 5. Press the **WRITE** button. | ||
| 6. Scan your BoltRing by holding it to the back of your phone (at the antenna location you found in Step 1). |
sat-engineer
approved these changes
Nov 30, 2025
Member
sat-engineer
left a comment
sat-engineer
left a comment
There was a problem hiding this comment.
ideally there would’ve been a separate PR for a new class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.