pygmt.project.py: Add input validation for geometry parameters#4415
Open
willschlitzer wants to merge 8 commits intoGenericMappingTools:mainfrom
Open
pygmt.project.py: Add input validation for geometry parameters#4415willschlitzer wants to merge 8 commits intoGenericMappingTools:mainfrom
willschlitzer wants to merge 8 commits intoGenericMappingTools:mainfrom
Conversation
Add input validation for 'endpoint', 'pole', and 'azimuth' to check for only one paramter being passed. Add testing to check that appropriate error is raised.
seisman
reviewed
Feb 14, 2026
seisman
reviewed
Feb 14, 2026
pygmt/tests/test_project.py
Outdated
Comment on lines
95
to
120
| @pytest.mark.parametrize( | ||
| ("kwargs"), | ||
| [ | ||
| { | ||
| "center": [0, -1], | ||
| "generate": 0.5, | ||
| "data": [0, 0], | ||
| "azimuth": 45, | ||
| "endpoint": [0, 1], | ||
| }, | ||
| { | ||
| "center": [0, -1], | ||
| "generate": 0.5, | ||
| "data": [0, 0], | ||
| "azimuth": 45, | ||
| "pole": [0, 90], | ||
| }, | ||
| { | ||
| "center": [0, -1], | ||
| "generate": 0.5, | ||
| "data": [0, 0], | ||
| "endpoint": [0, 1], | ||
| "pole": [0, 90], | ||
| }, | ||
| ], | ||
| ) |
Member
There was a problem hiding this comment.
Perhaps not a good idea to use pytest.mark.parametrize in this case.
seisman
added
maintenance
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Contributor
Author
|
/format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add input validation for 'endpoint', 'pole', and 'azimuth' to check for only one paramter being passed. Add testing to check that appropriate error is raised.