Refactor: Remove deprecated/missing header includes#133
Open
Rishabh1925 wants to merge 1 commit intoGeomScale:developfrom
Open
Refactor: Remove deprecated/missing header includes#133Rishabh1925 wants to merge 1 commit intoGeomScale:developfrom
Rishabh1925 wants to merge 1 commit intoGeomScale:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
bindings.hfile currently attempts to include several headers (e.g.,random.hpp,random/uniform_int.hpp) that are no longer present in the referenced version ofvolesti. This causes immediate build failures during compilation.The Fix
I have removed/commented out these invalid includes.
Verification
dingonow compiles and installs successfully without "file not found" errors.dingofunctionality (sampling) works correctly without these headers.