Fix gofmt lint failure in gthulhu_test.go#14
Merged
ianchen0119 merged 3 commits intomainfrom Feb 20, 2026
Merged
Conversation
Co-authored-by: ianchen0119 <42661015+ianchen0119@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Priority type to integer in SchedulingStrategy
Change Feb 20, 2026
Priority field type from bool to int in SchedulingStrategy
Co-authored-by: ianchen0119 <42661015+ianchen0119@users.noreply.github.com>
Copilot
AI
changed the title
Change
Fix gofmt lint failure in gthulhu_test.go
Feb 20, 2026
Priority field type from bool to int in SchedulingStrategy
ianchen0119
approved these changes
Feb 20, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a gofmt formatting violation introduced during a previous refactoring that changed the Priority field from bool to int. The formatting issue was an extra space before inline comments in test code, which caused CI to fail.
Changes:
- Fixed formatting in
gthulhu_test.goby removing extra space before inline comments (lines 386-387) - Updated all Priority field references from boolean to integer type across the codebase
- Updated test assertions to use integer comparisons instead of boolean checks
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugin/util/util.go | Changed Priority field type from bool to int in SchedulingStrategy struct |
| plugin/gthulhu/gthulhu_test.go | Updated test data and assertions to use integer Priority values; fixed gofmt violation with double space before inline comments |
| plugin/gthulhu/gthulhu.go | Updated logic to check Priority > 0 instead of boolean Priority |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing due to a
gofmtviolation introduced when updatingPriorityvalues frombooltointliterals — a double space was left before an inline comment, whichgofmt -srejects.Change
plugin/gthulhu/gthulhu_test.go:386: Remove extra space before// 10mscomment🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.