Skip to content

Fix gofmt lint failure in gthulhu_test.go#14

Merged
ianchen0119 merged 3 commits intomainfrom
copilot/update-priority-to-integer
Feb 20, 2026
Merged

Fix gofmt lint failure in gthulhu_test.go#14
ianchen0119 merged 3 commits intomainfrom
copilot/update-priority-to-integer

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

CI was failing due to a gofmt violation introduced when updating Priority values from bool to int literals — a double space was left before an inline comment, which gofmt -s rejects.

Change

  • plugin/gthulhu/gthulhu_test.go:386: Remove extra space before // 10ms comment
// Before
{PID: 100, Priority: 1, ExecutionTime: 10000000},  // 10ms

// After
{PID: 100, Priority: 1, ExecutionTime: 10000000}, // 10ms

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: ianchen0119 <42661015+ianchen0119@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Priority type to integer in SchedulingStrategy Change Priority field type from bool to int in SchedulingStrategy Feb 20, 2026
Copilot AI requested a review from ianchen0119 February 20, 2026 15:33
Co-authored-by: ianchen0119 <42661015+ianchen0119@users.noreply.github.com>
Copilot AI changed the title Change Priority field type from bool to int in SchedulingStrategy Fix gofmt lint failure in gthulhu_test.go Feb 20, 2026
@ianchen0119 ianchen0119 marked this pull request as ready for review February 20, 2026 15:39
Copilot AI review requested due to automatic review settings February 20, 2026 15:39
@ianchen0119 ianchen0119 merged commit 2c7a28a into main Feb 20, 2026
3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a gofmt formatting violation introduced during a previous refactoring that changed the Priority field from bool to int. The formatting issue was an extra space before inline comments in test code, which caused CI to fail.

Changes:

  • Fixed formatting in gthulhu_test.go by removing extra space before inline comments (lines 386-387)
  • Updated all Priority field references from boolean to integer type across the codebase
  • Updated test assertions to use integer comparisons instead of boolean checks

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
plugin/util/util.go Changed Priority field type from bool to int in SchedulingStrategy struct
plugin/gthulhu/gthulhu_test.go Updated test data and assertions to use integer Priority values; fixed gofmt violation with double space before inline comments
plugin/gthulhu/gthulhu.go Updated logic to check Priority > 0 instead of boolean Priority

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants