ADD: ocr options inputs for all ocr engines + fix for model training options and wait submission#435
Open
benleetownsend wants to merge 6 commits intomasterfrom
Open
ADD: ocr options inputs for all ocr engines + fix for model training options and wait submission#435benleetownsend wants to merge 6 commits intomasterfrom
benleetownsend wants to merge 6 commits intomasterfrom
Conversation
Contributor
jacobmanderson
left a comment
There was a problem hiding this comment.
maybe we can have a base ocr options class that different versions can subclass
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
dff1b88 to
452a612
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
Checklist:
Note
Medium Risk
Touches multiple client-facing request builders and expands OCR configuration surfaces; risk is mainly API/serialization compatibility and potential breaking behavior for callers relying on prior parameter types or implicit pagination.
Overview
Extends dataset OCR configuration support by adding new OCR option input types (including
READAPI_TABLES_V2) and plumbing them throughCreateDataset/CreateEmptyDataset, with stricter validation to ensure only one OCR options block is provided.Improves a few client request ergonomics/bugs:
ListGallerynow accepts structured filter dicts,UpdateModelGroupSettingscorrectly serializesmodel_training_optionsto JSON, andWaitForSubmissionsaccepts a single submission id and sets an explicitlimitto avoid over-fetching.Written by Cursor Bugbot for commit 452a612. This will update automatically on new commits. Configure here.