[MOB-12270] new-embedded-view-component #748

lposen · 2025-10-13T23:51:14Z

🔹 JIRA Ticket(s) if any

MOB-12270

✏️ Description

Added embedded view component

Testing

Start the app (see instructions under "start the app")
Sign in
Click on "Embedded"
Click "Sync Messages"
Select a View Type
Click "Get Messages"
The correct view type should be shown in the messages below
Change the view type
The new view type should show in the messages

Banner	Card	Notification

Start the app

In the root, run yarn install
cd into example
- run yarn install
- Run the rn server in one tab:
  - run yarn start --reset-cache
  - Do not close this tab
- Create a new tab in example and run yarn android
- Create a new tab in example and run yarn ios (or open the workspace and run with xcode)

…mbedded messaging

github-actions · 2025-10-13T23:52:48Z

Lines	Statements	Branches	Functions
	62.53% (409/654)	40.97% (109/266)	60.25% (141/234)

qltysh · 2025-10-13T23:52:51Z

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on emb-ootb/master by 0.54%.

Modified Files with Diff Coverage (4)

File	% Diff	Uncovered Line #s
src/embedded/components/IterableEmbeddedBanner.tsx	20.0%	10-14
src/embedded/components/IterableEmbeddedView.tsx	100.0%
src/embedded/components/IterableEmbeddedNotification.tsx	20.0%	10-17
src/embedded/components/IterableEmbeddedCard.tsx	20.0%	9-13
Total	47.8%

🤖 Increase coverage with AI coding...

In the `loren/embedded/MOB-12270-new-embedded-view-component` branch, add test coverage for this new code:

- `src/embedded/components/IterableEmbeddedBanner.tsx` -- Line 10-14
- `src/embedded/components/IterableEmbeddedCard.tsx` -- Line 9-13
- `src/embedded/components/IterableEmbeddedNotification.tsx` -- Line 10-17

🚦 See full report on Qlty Cloud »

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

qltysh · 2025-10-13T23:53:11Z

5 new issues

Tool	Category	Rule	Count
qlty	Duplication	Found 20 lines of similar code in 3 locations (mass = 75)	3
qlty	Structure	Function with many returns (count = 5): IterableEmbeddedView	1
qlty	Structure	Function with high complexity (count = 5): IterableEmbeddedView	1

src/embedded/components/IterableEmbeddedView.tsx

qltysh · 2025-12-24T19:41:00Z

src/embedded/components/IterableEmbeddedView.tsx

+    }
+  }, [viewType]);
+
+  return Cmp ? <Cmp {...props} /> : null;


Found 2 issues:

1. Function with many returns (count = 5): IterableEmbeddedView [qlty:return-statements]

2. Function with high complexity (count = 5): IterableEmbeddedView [qlty:function-complexity]

qltysh · 2026-01-29T21:35:18Z

src/embedded/components/IterableEmbeddedBanner.tsx

+      <Text>IterableEmbeddedBanner</Text>
+    </View>
+  );
+};


Found 20 lines of similar code in 3 locations (mass = 75) [qlty:similar-code]

qltysh · 2026-01-29T21:35:18Z

src/embedded/components/IterableEmbeddedCard.tsx

+      <Text>IterableEmbeddedCard</Text>
+    </View>
+  );
+};


Found 19 lines of similar code in 3 locations (mass = 75) [qlty:similar-code]

qltysh · 2026-01-29T21:35:18Z

src/embedded/components/IterableEmbeddedNotification.tsx

+      <Text>IterableEmbeddedNotification</Text>
+    </View>
+  );
+};


Found 23 lines of similar code in 3 locations (mass = 75) [qlty:similar-code]

…-component

…and unused styles

… props passing

… clarity on props and usage

lposen added 3 commits October 13, 2025 16:38

feat: add IterableEmbedded components and view type enumeration for e…

b9fbb06

…mbedded messaging

feat: export embedded components and types

3b252d1

feat: enhance Embedded component with view type selection and styling

8b6f82c

qltysh bot reviewed Oct 13, 2025

View reviewed changes

src/embedded/components/IterableEmbeddedView.tsx Show resolved Hide resolved

lposen added the embedded Issues/PRs related to Embedded Messages label Oct 14, 2025

lposen mentioned this pull request Oct 14, 2025

[MOB-7052] Embedded messaging feature #751

Merged

Base automatically changed from loren/embedded/MOB-12268-android-add-click-handling-and-track to loren/embedded/master December 24, 2025 19:39

qltysh bot reviewed Dec 24, 2025

View reviewed changes

Base automatically changed from loren/embedded/master to master January 29, 2026 21:32

qltysh bot reviewed Jan 29, 2026

View reviewed changes

lposen added 4 commits February 10, 2026 14:26

Merge branch 'master' into loren/embedded/MOB-12270-new-embedded-view…

a5558d6

…-component

refactor: clean up Embedded component by removing commented-out code …

d74383f

…and unused styles

test: add unit tests for IterableEmbeddedView component rendering and…

a8d3008

… props passing

docs: add JSDoc comments to IterableEmbeddedView component for better…

ba7fccc

… clarity on props and usage

lposen changed the base branch from master to emb-ootb/master February 10, 2026 23:13

lposen marked this pull request as ready for review February 10, 2026 23:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MOB-12270] new-embedded-view-component #748

[MOB-12270] new-embedded-view-component #748

Uh oh!

lposen commented Oct 13, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 13, 2025 •

edited

Loading

Uh oh!

qltysh bot commented Oct 13, 2025 •

edited

Loading

Uh oh!

qltysh bot commented Oct 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

qltysh bot Dec 24, 2025

Uh oh!

qltysh bot Jan 29, 2026

Uh oh!

qltysh bot Jan 29, 2026

Uh oh!

qltysh bot Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

[MOB-12270] new-embedded-view-component #748

Are you sure you want to change the base?

[MOB-12270] new-embedded-view-component #748

Uh oh!

Conversation

lposen commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Testing

Start the app

Uh oh!

github-actions bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

5 new issues

Uh oh!

Uh oh!

qltysh bot Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

lposen commented Oct 13, 2025 •

edited

Loading

github-actions bot commented Oct 13, 2025 •

edited

Loading

qltysh bot commented Oct 13, 2025 •

edited

Loading

qltysh bot commented Oct 13, 2025 •

edited

Loading