PyObject use numpy_ma.array to plot masked missings#596
Open
deszoeke wants to merge 1 commit intoJuliaPy:masterfrom
Open
PyObject use numpy_ma.array to plot masked missings#596deszoeke wants to merge 1 commit intoJuliaPy:masterfrom
deszoeke wants to merge 1 commit intoJuliaPy:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #596 +/- ##
==========================================
- Coverage 22.31% 22.13% -0.19%
==========================================
Files 4 4
Lines 363 366 +3
==========================================
Hits 81 81
- Misses 282 285 +3 ☔ View full report in Codecov by Sentry. |
|
Thank you, @deszoeke, for making the PR :-) if you need a (trivial) test: using Test
@test PyObject([1,missing]).mask[2] |
Author
|
Automatic checks fail (on ubuntu and windows) because fragile PyCall builds fail. @Alexander-Barth wrote:
Testing of PyPlot is quite minimal. PR deszoeke:patch-2 adds a test of plot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #593
tests to be added later