Conversation
added 30 commits
January 20, 2025 15:15
Contributor
|
@cjdoris @MilesCranmer |
added 9 commits
April 7, 2025 21:10
Member
Author
You will yeah but don't bother yet - this PR is likely to change some more. Sorry for the delay on reviewing your PR, my time is currently limited and focused on bugs, improving code quality and working towards v1, rather than new features, but I will get to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring the codebase, which has got a bit out of hand.
Internalssubmodulesrc/API/API.jluse a commonhave each internal submodule export its internal API so other submodules can just doInternals.Commonmodule which exports common functionality instead of needing to import functions from all over the placeusing ..Footo get everything it needsPyListetc withinWrapmaybe move testitems from test to src?