Skip to content

[#334] Fix mobile admin menu overflow and remove deprecated email button. #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DVidal1205 merged 3 commits into from
Feb 11, 2026
Merged

[#334] Fix mobile admin menu overflow and remove deprecated email button. #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c069c64
remove email button from admin dropdown
azizu06 Feb 11, 2026
0f51137
add max height and scroll to admin dropdown
azizu06 Feb 11, 2026
0f7e57b
remove email portal from admin dash
azizu06 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions apps/blade/src/app/_components/navigation/reusable-user-dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {
ChartPie,
FormInput,
Hotel,
Mail,
Settings,
ShieldCheck,
Swords,
Expand Down Expand Up @@ -66,16 +65,6 @@ export const systemItems: roleItems[] = [
or: ["READ_FORMS", "EDIT_FORMS", "IS_OFFICER"],
},
},
{
name: "Email",
component: (
<Mail color={USER_DROPDOWN_ICON_COLOR} size={USER_DROPDOWN_ICON_SIZE} />
),
route: "/admin/email",
requiredPermissions: {
or: ["EMAIL_PORTAL", "IS_OFFICER"],
},
},
{
name: "Assign Roles",
component: (
Expand Down
2 changes: 1 addition & 1 deletion apps/blade/src/app/_components/navigation/user-dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export function UserDropdown({ permissions }: UserDropdownProps) {
</Avatar>
</button>
</DropdownMenuTrigger>
<DropdownMenuContent className="mr-4 w-screen sm:w-56">
<DropdownMenuContent className="mr-4 max-h-[75vh] w-screen overflow-y-auto sm:max-h-[80vh] sm:w-56">
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR/issue mention removing the deprecated Email button, but /admin/email is still referenced elsewhere (e.g., apps/blade/src/app/admin/page.tsx) and there’s no app/admin/email route directory, so this remains a dead navigation path. Consider removing the Email Portal entry (and related permission-gating text) from the admin landing page in this PR to fully address #334 / the deprecation.

Copilot uses AI. Check for mistakes.
<DropdownMenuLabel>{data ? data.name : "My Account"}</DropdownMenuLabel>
<DropdownMenuSeparator />
<DropdownMenuGroup>
Expand Down
7 changes: 0 additions & 7 deletions apps/blade/src/app/admin/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
ChartPie,
FormInput,
Hotel,
Mail,
Settings,
ShieldCheck,
Swords,
Expand Down Expand Up @@ -155,12 +154,6 @@ export default async function Admin() {
icon: FormInput,
show: perms.READ_FORMS || perms.EDIT_FORMS || perms.IS_OFFICER,
},
{
href: "/admin/email",
label: "Email Portal",
icon: Mail,
show: perms.EMAIL_PORTAL || perms.IS_OFFICER,
},
{
href: "/admin/roles/configure",
label: "Configure Roles",
Expand Down
Loading